Skip to content

Commit

Permalink
Merge pull request #755 from Netflix/jdk17
Browse files Browse the repository at this point in the history
update infra to use JDK 17
  • Loading branch information
iuliiasobolevska authored Nov 18, 2024
2 parents 579ef15 + d2797b7 commit b48b124
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/nebula-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 8
java-version: 17
- uses: actions/cache@v4.1.1
id: gradle-cache
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nebula-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v4
with:
java-version: 8
java-version: 17
distribution: zulu
- uses: actions/cache@v4.1.1
id: gradle-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-gradle-wrapper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 8
java-version: 17
- name: Update Gradle Wrapper
uses: gradle-update/update-gradle-wrapper-action@v2
2 changes: 1 addition & 1 deletion .sdkmanrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Enable auto-env through the sdkman_auto_env config
# Add key=value pairs of SDKs to use below
java=8.0.312-zulu
java=17.0.11-zulu
15 changes: 8 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,18 @@ Working on the code base

IDE setup
-----
The DGS codebases are Kotlin based. We strongly recommend using Intellij because of the excellent support for Kotlin and
Gradle. You can use the free [Intellij Community Edition](https://www.jetbrains.com/idea/download/).
The DGS codebases are Kotlin based.
We strongly recommend using IntelliJ because of the excellent support for Kotlin and Gradle.
You can use the free [IntelliJ Community Edition](https://www.jetbrains.com/idea/download/).

Clone and open the project using the "project from version control feature" and let Gradle import all dependencies. Note
that we build on Java 8, so a Java 8 JDK is required. If you don't have a JDK, you can use [sdkman](https://sdkman.io/)
or [Intellij](https://www.jetbrains.com/help/idea/sdk.html) to install one. Because almost all the code is Kotlin, we
don't miss any language features of newer Java releases while supporting a broad range of older releases.
Clone and open the project using the "project from version control feature" and let Gradle import all dependencies.
Note that we build on Java 17, so a Java 17 JDK is required.
If you don't have a JDK, you can use [sdkman](https://sdkman.io/) or [IntelliJ](https://www.jetbrains.com/help/idea/sdk.html) to install one.
Because almost all the code is Kotlin, we don't miss any language features of newer Java releases while supporting a broad range of older releases.

Code conventions
-----
We use the standard Kotlin coding conventions. Intellij should select the correct style automatically because we checked
We use the standard Kotlin coding conventions. IntelliJ should select the correct style automatically because we checked
in the `.idea/codeStyle` folder. Furthermore, we're also using [Ktlint](https://ktlint.github.io/). You can run
formatting manually using Gradle:

Expand Down
2 changes: 1 addition & 1 deletion graphql-dgs-codegen-core/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM dockerregistry.test.netflix.net:7002/platform/java/8:latest
FROM dockerregistry.test.netflix.net:7002/platform/java/17:latest

COPY build/distributions/*.tar /app/

Expand Down

0 comments on commit b48b124

Please sign in to comment.