Skip to content

Commit

Permalink
Do not check metadata update as simultaneous zset metadata updates ca…
Browse files Browse the repository at this point in the history
…n cause false negatives. (#262)
  • Loading branch information
kishorekasi authored Apr 2, 2019
1 parent 1472c1f commit ffddaba
Showing 1 changed file with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4275,11 +4275,6 @@ public Long ehset(final String key, final String field, final String value, fina
final Response<Long> hResponse = pipeline.hset(ehashDataKey(key), field, value);
pipeline.sync();

// If metadata operation failed, remove the data and throw exception
if (zResponse.get() != 1) {
d_hdel(ehashDataKey(key), field);
throw new DynoException("Failed to set field:" + field + "; Metadata operation failed:" + zResponse.get());
}
return hResponse.get();
}

Expand Down Expand Up @@ -4462,11 +4457,6 @@ public String ehmset(final String key, final Map<String, Pair<String, Long>> has
final Response<String> hResponse = pipeline.hmset(ehashDataKey(key), fields);
pipeline.sync();

// If metadata operation failed, remove the data and throw exception
if (zResponse.get() != hash.size()) {
d_hdel(ehashDataKey(key), fields.keySet().toArray(new String[0]));
throw new DynoException("Failed to set fields; Metadata operation failed:" + zResponse.get());
}
return hResponse.get();
}

Expand Down

0 comments on commit ffddaba

Please sign in to comment.