MSET and MSETNX #206
MSET and MSETNX #206
Conversation
| @@ -134,7 +134,7 @@ private MultiKeyOperation(final List<String> keys, final OpName o) { | |||
| this.op = o; | |||
| } | |||
|
|
|||
| @Override | |||
| @Override | |||
There was a problem hiding this comment.
indentation. I just do not get what is the standard here.
| } else { | ||
| return connPool.executeWithFailover(new CompressionValueMultiKeyOperation<Long>(Arrays.asList(keysvalues), OpName.MSETNX) { | ||
| @Override | ||
| public Long execute(final Jedis client, final ConnectionContext state) throws DynoException { |
There was a problem hiding this comment.
Where are we compressing the values here?
| return connPool.executeWithFailover(new CompressionValueMultiKeyOperation<String>(Arrays.asList(keysvalues), OpName.MSET) { | ||
| @Override | ||
| public String execute(final Jedis client, final ConnectionContext state) throws DynoException { | ||
| return client.mset(keysvalues); |
There was a problem hiding this comment.
same, no compression happening here
|
|
||
| String[] compressMultiKeyValue(ConnectionContext ctx, String... value); | ||
|
|
||
| String decompressValue(ConnectionContext ctx, String value); |
There was a problem hiding this comment.
any reason why this doesnt take a list of strings?
There was a problem hiding this comment.
In multi-key write operations, we receive String... keyValues which is a combination of keys and values and we return either a String or Long. In multi-key read operations, the API receives a String keys which is only the keys that we want to be read and we return a List of values. The list of values is being transformed through the CollectionUtils.transform to each independent components (this is how you had set it up and it looks good to me). Then we take each value and we decompress. Hence, our compressMultiKeyValue has numerous inputs and has some logic to perform the compression like selecting every second element which is the values. The decompressValue does not have any special logic other than decompressing each value one-by-one
| Logger.warn( | ||
| "UNABLE to compress [" + value + "] for key [" + getStringKey() + "]; sending value uncompressed"); | ||
| } | ||
| } |
| for (int i = 0 ; i < items.size() ; i++) { | ||
| if( i%2 == 0 ) { | ||
| String value = items.get(i); | ||
|
|
There was a problem hiding this comment.
please maintain that comment about 2
| @@ -241,48 +240,56 @@ public String decompressValue(String value, ConnectionContext ctx) { | |||
| * <ul> | |||
| * <lh>String Operations</lh> | |||
| * <li>{@link #mget(String...) MGET}</li> | |||
| * <li>{@link #mset(String...) MSET}</li> | |||
| * <li>{@link #msetnx(String...) MSETNX}</li> | |||
| * </ul> | |||
| * | |||
| * @param <T> | |||
| * the parameterized type | |||
| */ | |||
| private abstract class CompressionValueMultiKeyOperation<T> extends MultiKeyOperation<T> | |||
There was a problem hiding this comment.
may be rename this to alternate value Multi key operation etc? just an idea
There was a problem hiding this comment.
It is not an alternate value. It is a key-value pair.
|
LGTM |
Adding support for multi-key operations like MSET and MSETNX.