Disable demo properties that affect the client in production #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, the demo properties get picked up by the client even though it's not supposed to which causes incorrect behavior in the client. The properties in question are LOCAL_RACK and LOCAL_DATACENTER which return the values set in the demo.properties file in production, causing ConfigUtils.getLocalZone() and ConfigUtils.getDataCenter() to return potentially incorrect values.
rsrinivasanNetflix
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, the demo properties get picked up by the client even though
it's not supposed to which causes incorrect behavior in the client.
The properties in question are LOCAL_RACK and LOCAL_DATACENTER which
return the values set in the demo.properties file in production, causing
ConfigUtils.getLocalZone() and ConfigUtils.getDataCenter() to return
potentially incorrect values.
TODO: Figure out why demo.properties gets picked up and disallow it from happening.