Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck handler should support returning any InstanceInfo Status #145

Closed
NiteshKant opened this issue Jul 5, 2014 · 0 comments
Closed
Assignees
Milestone

Comments

@NiteshKant
Copy link
Contributor

Current HealthCheckCallback only supports a binary status which translates to UP and DOWN status for InstanceInfo.
In order to have healthcheck status not used in STARTING state, eureka client does not invoke the healthcheck callback when the status is STARTING.
This forces applications to spread the instance status update in two places:

  • HealthCheckCallback giving UP/DOWN status.
  • Application code transitioning status from STARTING to UP

This change will provide a new interface (deprecating the old HealthCheckCallback interface), that will provide the InstanceInfo.InstanceStatus as its return value. This will enable applications to have the instance status update logic in one place i.e. the HealthCheckHandler

@NiteshKant NiteshKant added this to the 1.1.135 milestone Jul 5, 2014
@NiteshKant NiteshKant self-assigned this Jul 5, 2014
NiteshKant pushed a commit to NiteshKant/eureka that referenced this issue Jul 5, 2014
NiteshKant pushed a commit to NiteshKant/eureka that referenced this issue Jul 6, 2014
NiteshKant added a commit that referenced this issue Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant