Support configuration of custom SSLContext/HostnameVerifier #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiangdavidliu @twicksell Could I get a review on this? |
|
@mattnelson we'll take a look. Thanks for the PR. |
qiangdavidliu
suggested changes
Oct 27, 2017
| instanceInfo.getActionType().name()}; | ||
| logger.debug("The instance id %s is found with status %s and actiontype %s", args); | ||
| logger.debug("The instance id {} is found with status {} and actiontype {}", | ||
| instanceInfo.getStatus().name(), instanceInfo.getActionType().name()); |
There was a problem hiding this comment.
You missed an instanceInfo.getId() here.
| @@ -112,13 +116,18 @@ public void shutdown() { | |||
| public static JerseyEurekaHttpClientFactory create(EurekaClientConfig clientConfig, | |||
| Collection<ClientFilter> additionalFilters, | |||
| InstanceInfo myInstanceInfo, | |||
| AbstractEurekaIdentity clientIdentity) { | |||
There was a problem hiding this comment.
I know this is very unlikely to be used outside of internal classes, but give that the method has a public signature, do you mind creating a new method with the optionals and delegate over (rather than changing) from the original? Thanks.
| @@ -78,14 +80,19 @@ public void shutdown() { | |||
| public static Jersey2ApplicationClientFactory create(EurekaClientConfig clientConfig, | |||
| Collection<ClientRequestFilter> additionalFilters, | |||
| InstanceInfo myInstanceInfo, | |||
| AbstractEurekaIdentity clientIdentity) { | |||
There was a problem hiding this comment.
I know this is very unlikely to be used outside of internal classes, but give that the method has a public signature, do you mind creating a new method with the optionals and delegate over (rather than changing) from the original? Thanks.
qiangdavidliu
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #816
Supports configuration of custom SSLContext/HostnameVerifier for jersey1/jersey2 implementations.