Prevent "null" url server url prefix #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| sb.append(clientConfig.getEurekaServerURLContext()); | ||
| } | ||
| String serviceUrl = sb.toString(); |
There was a problem hiding this comment.
Hi. To replicate the existing behaviour, when the context is not null, this should append an additional /.
There was a problem hiding this comment.
You are right. Added commit to append slash.
| if (!clientConfig.getEurekaServerURLContext().startsWith("/")) { | ||
| sb.append("/"); | ||
| } | ||
| sb.append(clientConfig.getEurekaServerURLContext()); |
There was a problem hiding this comment.
there should still be a final check here that
if (!clientConfig.getEurekaServerURLContext().endsWith("/") {
sb.append("/");
}
|
Merging this and addressing the PR comment in a separate PR. |
qiangdavidliu
added a commit
to qiangdavidliu/eureka
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set
shouldUseDnsas true with nulleurekaServer.context,EndpointUtils#getServiceUrlsFromDNSappends "null" string to service url postfix.e.g. http://ec2-10-0-0-1.ap-northeast-2.compute.amazonaws.com/null/
Fixed this.