Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The getHostCandidates method improves #1013

Merged
merged 1 commit into from
Nov 28, 2017
Merged

The getHostCandidates method improves #1013

merged 1 commit into from
Nov 28, 2017

Conversation

holy12345
Copy link
Contributor

Prevent retryableClientQuarantineRefreshPercentage from being greater than 1, causing Eureka Client to not register with Eureka Server。

Corresponding issues for #1012

Prevent retryableClientQuarantineRefreshPercentage from being greater than 1, causing Eureka Client to not register with Eureka Server。

Corresponding issues for #1012
@qiangdavidliu qiangdavidliu merged commit d9ad6d5 into Netflix:master Nov 28, 2017
@qiangdavidliu
Copy link
Contributor

Thanks @holy12345 .

@holy12345
Copy link
Contributor Author

@qiangdavidliu Thank you, may I ask which version of eureka can see this fix. Best wishes!

@qiangdavidliu
Copy link
Contributor

Hi @holy12345 we are probably going to look at some of the other outstanding PRs before a new release. This PR only adds a guard against misconfiguration (i.e. when the config value is specified incorrectly as > 1), and can be addressed for now by appropriately setting the config. Is there an urgent need for a release? Thanks.

@holy12345
Copy link
Contributor Author

holy12345 commented Dec 6, 2017

@qiangdavidliu Thank you very much for your reply : )
Not very urgent, but I'm worried that the user does not know the meaning of this parameter (the official document did not say.) If the value is greater than 1 may lead to some problems with the production.
In addition, I submitted two PRs(#1021 #1020), please check, if there is no problem, hope to merge it.
Finally, I would like to ask you, can you give me your email address?
best wishes:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants