Full DiscoveryClient Governation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RefreshCallback so that custom instance status check logic can be implemented after getting an update from discovery. Add Cancel/Register support to MockRemoteEureakServer Add eureka-lifecycle project with a guide module for eureka bindings. Includes binding for an Rx Observable<Boolean> with running instance up status notification
Improve MockRemoteEurekaServer
handler Get rid of Rx status stream Revert changes to MockRemoteEurekaServer until it can be fixed properly
…ve existing binding errors
Make MockRemoteEruekaServer an ExternalResource so it can be used as an @rule
Full DI support for DiscoveryClient with backwards compatibility for DiscoveryManager.getInstance(). There are default implementations (cloud) for all DiscoveryClient components and DiscoveryClient can now be injected directly without the need for a guice module to specify any of the bindings. Namespace override is done by binding a String annotated with @EurekaNamespace in a bootstrap module.
|
eureka-pull-requests #77 SUCCESS |
|
eureka-pull-requests #78 SUCCESS |
|
eureka-pull-requests #79 SUCCESS |
| @@ -1,2 +1,2 @@ | |||
| rootProject.name='eureka' | |||
| include 'eureka-client','eureka-server','eureka-core','eureka-resources' | |||
| include 'eureka-client','eureka-server','eureka-core','eureka-resources','eureka-lifecycle' | |||
There was a problem hiding this comment.
eureka-lifecycle need to be removed.
|
eureka-pull-requests #80 FAILURE |
|
eureka-pull-requests #81 FAILURE |
|
eureka-pull-requests #82 ABORTED |
NiteshKant
added a commit
that referenced
this pull request
Apr 16, 2014
Full DiscoveryClient Governation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #93 with full DI support for DiscoveryClient without the need for a Guice module. This implementation is also fully backwards compatible with DiscoveryManager.getInstance()