-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full DiscoveryClient Governation #103
Conversation
Add RefreshCallback so that custom instance status check logic can be implemented after getting an update from discovery. Add Cancel/Register support to MockRemoteEureakServer Add eureka-lifecycle project with a guide module for eureka bindings. Includes binding for an Rx Observable<Boolean> with running instance up status notification
Improve MockRemoteEurekaServer
handler Get rid of Rx status stream Revert changes to MockRemoteEurekaServer until it can be fixed properly
…ve existing binding errors
Make MockRemoteEruekaServer an ExternalResource so it can be used as an @rule
Full DI support for DiscoveryClient with backwards compatibility for DiscoveryManager.getInstance(). There are default implementations (cloud) for all DiscoveryClient components and DiscoveryClient can now be injected directly without the need for a guice module to specify any of the bindings. Namespace override is done by binding a String annotated with @EurekaNamespace in a bootstrap module.
eureka-pull-requests #77 SUCCESS |
eureka-pull-requests #78 SUCCESS |
eureka-pull-requests #79 SUCCESS |
@@ -1,2 +1,2 @@ | |||
rootProject.name='eureka' | |||
include 'eureka-client','eureka-server','eureka-core','eureka-resources' | |||
include 'eureka-client','eureka-server','eureka-core','eureka-resources','eureka-lifecycle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eureka-lifecycle need to be removed.
eureka-pull-requests #80 FAILURE |
eureka-pull-requests #81 FAILURE |
eureka-pull-requests #82 ABORTED |
Full DiscoveryClient Governation
Alternative implementation to #93 with full DI support for DiscoveryClient without the need for a Guice module. This implementation is also fully backwards compatible with DiscoveryManager.getInstance()