Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DefaultEurekaClientConfig units #107

Merged
merged 1 commit into from
Apr 25, 2014
Merged

Fix DefaultEurekaClientConfig units #107

merged 1 commit into from
Apr 25, 2014

Commits on Apr 24, 2014

  1. Fix DefaultEurekaClientConfig units 

    EurekaServiceUrlPollInterval is named
getEurekaServiceUrlPollIntervalSeconds in EurekaClientConfig interface
but serviceUrlPollIntervalMs in config files. Its default looks
suspiciously like it shouldn't be multiplied by 1000. This config is
actually used as seconds. Changed to convert the config
serviceUrlPollIntervalMs to into seconds.

EurekaServerReadTimeoutSeconds and EurekaServerConnectTimeoutSeconds
were both being contributed as millseconds and used as milliseconds.
Changed to seconds in config files and use of the config changed to use
seconds.
    @pgkelley4
    pgkelley4 committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    b24cf11 View commit details
    Browse the repository at this point in the history