Concurrent register of custom healthcheck handler in DiscoveryClient #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is possibility to rewrite healthcheck handler by default one. Root cause: after not thread safe null check DiscoveryClient will register default healthcheck handler even if during creation of that, custom one will be provided. Resolution summary: wrap healthcheck handler in AtomicReference and set default implementation only if reference still contain null
|
@tdanylchuk looks good, thanks for the contribution. |
|
My pleasure, thank you for supporting the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients try to register their health checks and fail since there is possibility to rewrite healthcheck handler by default one.
Root cause:
after not thread safe null check DiscoveryClient will register default healthcheck handler even if during creation of that, custom one will be provided.
Resolution summary:
wrap healthcheck handler in AtomicReference and set default implementation only if reference still contain null.
Example is spring-cloud-netflix project and spring-cloud/spring-cloud-netflix#2490 issue.