Fix 1098

[holy12345]

Hi @qiangdavidliu

This PR fix #1098 please check it.

Thanks : )

[qiangdavidliu]

@holy12345 thanks for the PR. This looks good in theory, though I would like to get some additional verification on whether this is safe to do as removal of apps is not something that expected in current client behaviour. Can you please add some testing to verify? DiscoveryClientRegistryTest would be a good starting point for this. Thanks.

[holy12345]

@qiangdavidliu Great thanks : )

I will add some test for this PR.
One more things could you please give me your personal email? If you think it inconvenient to disclose it in public, I can give you my email address(Because I want more discuss with you about eureka).

My email address is spring_holy@163.com

Thanks again

[holy12345]

Hi @qiangdavidliu First of all thank you!

I add some test case for this PR, please you check it .

You say

removal of apps is not something that expected in current client behaviour

So I think in some case there have many application has no instanceInfo when merge the delta information(the action type is DELETE)

According to your thoughts which is best ?

• When application has no instanceInfo, we remove application(this PR logic)

• Optimize the original logic, the code like this

if (ActionType.DELETED.equals(instance.getActionType())) {
    Application existingApp = applications.getRegisteredApplications(instance.getAppName());
    if (existingApp != null) {
        logger.debug("Deleted instance {} to the existing apps ", instance.getId());
        applications.getRegisteredApplications(instance.getAppName()).removeInstance(instance);
    }
}

Thanks again : )

[qiangdavidliu]

Looks good, thanks @holy12345 .