EUREKA-1087 Add config parameter eureka.myUrl #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould treat as its own (for cases when each Eureka node is behind LB and does not simply check replica URLs against own IP/host)
|
Hm, on my local machine all tests pass well, is there any way to re-run Travis build? |
|
Thanks @mgtriffid , I retriggered the travis build. |
|
build passes. Thanks @mgtriffid |
mattnelson
reviewed
Aug 2, 2018
| * Allows to configure URL which Eureka should treat as its own during replication. In some cases Eureka URLs don't | ||
| * match IP address or hostname (for example, when nodes are behind load balancers). Setting this parameter on each | ||
| * node to URLs of associated load balancers helps to avoid replication to the same node where event originally came | ||
| * to. Important: you need to configure the whole URL including scheme and path, like |
There was a problem hiding this comment.
Mention that this is because of the value being parsed from eureka.serviceUrl.default instead of the host from the instance registration.
|
Thanks for approval and merge @qiangdavidliu ! |
|
@mgtriffid we should have a release out some time this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to specify URL Eureka should treat as its own (for cases when each Eureka node is behind LB and does not simply check replica URLs against own IP/host)