EUREKA-1154 Return 404 if instance is not found when updating metadata #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metadata via REST API
|
Fixes #1154. |
troshko111
approved these changes
Nov 14, 2018
| @@ -118,7 +118,7 @@ public Response renewLease( | |||
| } | |||
| // Check if we need to sync based on dirty time stamp, the client | |||
| // instance might have changed some value | |||
| Response response = null; | |||
There was a problem hiding this comment.
This change is unrelated and I'd suggest to submit a separate PR for style only fixes if you're interested.
| } | ||
| MultivaluedMap<String, String> queryParams = uriInfo.getQueryParameters(); | ||
| Set<Entry<String, List<String>>> entrySet = queryParams.entrySet(); | ||
| Map<String, String> metadataMap = instanceInfo.getMetadata(); | ||
| // Metadata map is empty - create a new map | ||
| if (Collections.emptyMap().getClass().equals(metadataMap.getClass())) { | ||
| metadataMap = new ConcurrentHashMap<String, String>(); |
There was a problem hiding this comment.
Again would suggest to separate, but I understand these are minor so up to you.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.