Add unit tests for com.netflix.discovery.util.EurekaEntityFunctions #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troshko111
requested changes
Jun 11, 2019
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
|
Thanks for the PR! |
|
btw, if you're looking for test-related tasks, fixing the flakiness would be the top one probably. |
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
3923472
to
61be37e
Compare
Do you have any specific class in mind which you would like me to have a look at? :) |
troshko111
requested changes
Jun 12, 2019
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTests.java
Outdated
Show resolved
Hide resolved
no not really, just run the tests multiple times and see if you get any intermittent failures, the ones failing would be flaky and something we'd appreciate to have fixed. |
These tests were written using Diffblue Cover.
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
61be37e
to
df91064
Compare
|
Hi @troshko111 just following up and wondering if you would like me to make any changes to the PR? |
|
Sorry did not realize this got updated, for the future can you please not rebase PR iterations? It makes the review very hard (every iteration has to be reviewed again as a completely new change without any intermediate diffs). |
troshko111
requested changes
Jul 2, 2019
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTest.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTest.java
Show resolved
Hide resolved
These tests were written using Diffblue Cover.
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
e9cb921
to
66a4ffd
Compare
troshko111
approved these changes
Jul 8, 2019
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTest.java
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTest.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTest.java
Outdated
Show resolved
Hide resolved
eureka-client/src/test/java/com/netflix/discovery/util/EurekaEntityFunctionsTest.java
Show resolved
Hide resolved
These tests were written using Diffblue Cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that
com.netflix.discovery.util.EurekaEntityFunctionsis not fully tested.I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important.