make AmazonInfo deserializer more robust #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, it was easy to trigger an endless loop in
`StringInterningAmazonInfoBuilder` if the `dataCenterInfo` payload
wasn't exactly right. For example, it could be done with:
```
"dataCenterInfo": {
"@Class": "com.netflix.appinfo.AmazonInfo",
"metadata": {
"instance-id": "i-12345"
}
}
```
If there wasn't a field before `metadata` it would skip over the
`metadata` field and then end up in an endless loop because it
didn't check for the end of input.
spencergibb
approved these changes
Jul 14, 2019
troshko111
approved these changes
Jul 15, 2019
|
Thanks @brharrington! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, it was easy to trigger an endless loop in
StringInterningAmazonInfoBuilderif thedataCenterInfopayloadwasn't exactly right. For example, it could be done with:
If there wasn't a field before
metadatait would skip over themetadatafield and then end up in an endless loop because itdidn't check for the end of input.