Cleanup resources on web-app shutdown (#1207) #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servo is in maintenance mode and we aren't investing much new effort into it, however, PRs that have minimal risk will be considered. |
troshko111
requested changes
Nov 8, 2019
| @@ -22,7 +23,7 @@ public void testThreadCount() throws InterruptedException { | |||
| private boolean containsJerseyThread() { | |||
There was a problem hiding this comment.
Probably worth renaming now.
There was a problem hiding this comment.
Renamed to containsClientThread.
eureka-core/src/main/java/com/netflix/eureka/registry/PeerAwareInstanceRegistryImpl.java
Show resolved
Hide resolved
eureka-core/src/main/java/com/netflix/eureka/registry/PeerAwareInstanceRegistryImpl.java
Show resolved
Hide resolved
eureka-core/src/main/java/com/netflix/eureka/registry/ResponseCacheImpl.java
Show resolved
Hide resolved
troshko111
approved these changes
Nov 11, 2019
|
Thanks @stovocor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow a clean shutdown, I canceled various timers and unregistered a number of Servo monitors. The
CurrentRequestVersiongot aremovemethod so that theThreadLocalcan be cleared after use.The (in my opinion) only ugly solution is
ServoControlwhich stops the executor of Servo since the library seems to be no longer maintained.