decrement expectedNumberOfClientsSendingRenews for expired leases #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the logic that decrements the expected number of clients into cancelInternal - this should ensure that we're calling it both for explict cancels as well as well as when the instance lease expires. Fixes Netflix#1266
|
I couldn't find any existing test coverage for this, happy to add some if ya'll have any pointers to where to start |
troshko111
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logic that decrements the expected number of clients into
internalCancel- this should ensure that we're calling it both forexplicit cancels as well as well as when the instance lease expires.
Fixes #1266