Add stats for DiscoveryClient #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yobennett
requested review from
casualjim,
drobertduke,
troshko111,
snowp,
eos2102 and
philrud
yobennett
removed request for
casualjim,
drobertduke,
snowp,
eos2102 and
philrud
troshko111
approved these changes
Apr 1, 2020
eureka-client/src/main/java/com/netflix/discovery/DiscoveryClient.java
Outdated
Show resolved
Hide resolved
eureka-client/src/main/java/com/netflix/discovery/DiscoveryClient.java
Outdated
Show resolved
Hide resolved
We introduce a nested class for `DiscoveryClient` to make it easier for users to read helpful attributes that can assist in log analysis and debugging. Most of these attributes are captured by existing metrics: * `initTimestampMs`: timestamp when the client was initialized * `localRegistrySize`: number of instances for all applications * `lastSuccessfulRegistryFetchTimestampMs`: timestamp for last successful fetch * `lastSuccessfulHeartbeatTimestampMs`: timestamp for last successful heartbeat We add a new attribute called `initLocalRegistrySize`, which is the number of instances for all applications read when the client was initialized. We include a helper method that uses this attribute so that users can determine whether the client's initial fetch of registry information succeeded or failed. Note that other accessors are suffixed with `Ms` (for milliseconds) to denote the time unit. Additionally, we update the existing `registrySize` with the value from `initLocalRegistrySize` during initialization instead of waiting until the first local registry refresh.
yobennett
force-pushed
the
feature/add-discovery-client-stats
branch
from
b64430a
to
706c21c
Compare
troshko111
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a nested class for
DiscoveryClientto make it easier for users to read helpful attributes that can assist in log analysis and debugging. Most of these attributes are captured by existing metrics:initTimestampMs: timestamp when the client was initializedlocalRegistrySize: number of instances for all applicationslastSuccessfulRegistryFetchTimestampMs: timestamp for last successful fetchlastSuccessfulHeartbeatTimestampMs: timestamp for last successful heartbeatWe add a new attribute called
initLocalRegistrySize, which is the number of instances for all applications read when the client was initialized. We include a helper method that uses this attribute so that users can determine whether the client's initial fetch of registry information succeeded or failed. Note that other accessors are suffixed withMs(for milliseconds) to denote the time unit.Additionally, we update the existing
registrySizewith the value frominitLocalRegistrySizeduring initialization instead of waiting until the first local registry refresh.