-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve endpoint zone from metadata #1287
Conversation
The change LGTM, but can you elaborate on the bug and add some tests showing how it fixes it? |
Sorry. eureka.client.transport.bootstrapResolverStrategy=composite During the test, it was found that the client lost the server zone information. Finally found that the more reasonable way to modify is to add a few lines of code submitted. |
I will try to add some tests. |
Test was done. |
Sorry for the delay, this fell off my attention, I promise to have a short turnaround now. |
My eureka server was build with spring-cloud-starter-netflix-eureka-server. On server side, the framework build instances use dataCenterInfo type of |
Yeah I think this is reasonable, the current AWS/non-AWS separation is weak so I don't see a better place to do this tbh. Thanks and sorry for the delay. |
No worries. |
endpoint zone can be get from metadata