Cleanup Issues Found by Muse

[nescohen]

This PR cleans up some issues found by a new static analysis platform we just released called Muse. We’ve been using Eureka as a test case after being pointed to it by someone at Netflix and wanted to contribute fixes for some of the issues it found.

This PR addresses these bug types among others:

• https://errorprone.info/bugpattern/LockNotBeforeTry

• https://errorprone.info/bugpattern/ModifyCollectionInEnhancedForLoop

• https://fbinfer.com/docs/next/all-issue-types/#null_dereference

[nescohen]

You can see the rest of the findings here. When Muse is enabled on a repo, it runs on every pull request and adds comments that flag any new issues introduced by the proposed code change. So it’s a way to bring attention to issues like these “in the moment” when it’s easier to fix them. It looks like this. If you’d like to enable it, you can install the GitHub App from here. It’s free for open source.

[troshko111]

LGTM except the line removal in eureka-client/src/main/java/com/netflix/discovery/endpoint/EndpointUtils.java

[troshko111]

LGTM except the line removal in eureka-client/src/main/java/com/netflix/discovery/endpoint/EndpointUtils.java

Never mind, I did not notice at first.

[troshko111]

Thanks for sending this over!

[nescohen]

@troshko111, No problem dude. Happy to help!