Remove redundant metadata synchronization (#1424) #1426
Conversation
|
Interesting, I assume this is a perf issue? |
|
@spencergibb yeah a user reported contention under load, and I honestly can't see any evidence a thread safe map is required (per contract or per actual usage). LMK what your thoughts are on this. |
|
I haven't either and can't guess any future issues |
|
After a conversation with @tcellucci we figured that it should not be a breaking change barring use cases where users mutate the metadata of instances from the registry (a bad idea in general) without explicitly syncing access (an even worse idea). I will merge this but keep an open mind about potential effects, if they prove to be widespread, it may get reverted or put behind a property (sync map by default). For now I don't think it warrants to be behind a prop, it's below my safety threshold. |
No description provided.