Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call size method on Application to avoid copying instance info #1511

Merged
merged 1 commit into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. Call size method on Application to avoid copying instance info

    DiscoveryClient called getInstancesAsIsFromEureka in a couple locations to get
    the number of instances for an application, when Application already has a method
    for this purpose that doesn't also incur the overhead of defensively copying.
    
    Additionally, fix a concurrency bug in Application.size, as it was
    accessing the underlying instances field without synchronization.
    kilink committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    418f1b1 View commit details
    Browse the repository at this point in the history