1.x new transport enhancements #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qiangdavidliu
commented
Oct 22, 2015
qiangdavidliu
commented
- add config to define quarantine clear condition
- better metrics and logging
- adding jitter to sessionedClient's session duration
- better metrics and logging
|
NetflixOSS » eureka » eureka-pull-requests #500 SUCCESS |
| int threshold = candidateHosts.size() * transportConfig.getRetryableClientQuarantineRefreshPercentage() / 100; | ||
| if (quarantineSet.isEmpty()) { | ||
| // no-op | ||
| } else if (quarantineSet.size() >= threshold) { |
There was a problem hiding this comment.
I am not sure if this is good approach. If first 50% servers are down, and threshold is 50%, the client will never be able to connect to any healthy instance, as quarantine set will be just before the first live instance reset to zero.
There was a problem hiding this comment.
Good point. However we should also also not have it so that if there is only a single good server left, then we send a thundering herd there.
|
NetflixOSS » eureka » eureka-pull-requests #501 SUCCESS |
qiangdavidliu
added a commit
that referenced
this pull request
Oct 22, 2015
1.x new transport enhancements
|
hello, why add "adding jitter to sessionedClient's session duration" . thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.