Refactoring AmazonInfo refresh into common class #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qiangdavidliu
commented
Sep 7, 2016
qiangdavidliu
commented
- other minor clean ups
- Minor clean ups
| /** | ||
| * A holder class for AmazonInfo that exposes some APIs to allow for refreshes. | ||
| */ | ||
| public class RefreshableAmazonInfoHolder { |
There was a problem hiding this comment.
seems like this class should implement standard interface like Supplier or Provider, for better interop with java api
There was a problem hiding this comment.
Yeah thought about that too, I'll stick with Provider for now.
|
name AmazonInfo is overly broad; they (amazon guys) call it InstanceMetadata in the documentation and I think that's on-target. |
|
yeah that's stuck forever unfortunately. |
|
@qiangdavidliu thanks for jumping on this so quickly! |
This was referenced Sep 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.