Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Grapher#graph roots check to be isEmpty instead of null #348

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Change Grapher#graph roots check to be isEmpty instead of null #348

merged 1 commit into from
Feb 20, 2018

Conversation

nathanschile
Copy link

Was getting a empty roots graph when using the Grapher class. roots can never be null, though it can be empty. Changed the graph method to check isEmpty on roots instead of null.

@qiangdavidliu qiangdavidliu merged commit e6c72ea into Netflix:master Feb 20, 2018
@qiangdavidliu
Copy link
Contributor

thanks @nathanschile

@nathanschile nathanschile deleted the fix-grapher-null-root branch February 21, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants