-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 3] Refactoring Mantis Master Client code into a Gateway interface that defines the spec and a curator based implementation that matches that. #147
Conversation
...ol-plane-client/src/main/java/io/mantisrx/server/master/client/HighAvailabilityServices.java
Show resolved
Hide resolved
...lane-client/src/main/java/io/mantisrx/server/master/client/HighAvailabilityServicesUtil.java
Show resolved
Hide resolved
private final AsyncHttpClient apiClient; | ||
|
||
@Override | ||
public CompletableFuture<Ack> updateStatus(Status status) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment please. also context on why this was added.
…ce that defines the spec and a curator based implementation that matches that. Refactored all usages of the mantis mantis client to make use of the interface instead of the actual implementation
7091259
to
90b366c
Compare
@@ -43,13 +45,16 @@ | |||
zkProps.put("mantis.zookeeper.connectString", "100.67.80.172:2181,100.67.71.221:2181,100.67.89.26:2181,100.67.71.34:2181,100.67.80.18:2181"); | |||
zkProps.put("mantis.zookeeper.leader.announcement.path", "/leader"); | |||
zkProps.put("mantis.zookeeper.root", "/mantis/master"); | |||
zkProps.put("mantis.localmode", "false"); | |||
} | |||
|
|||
MasterClientWrapper clientWrapper = null; | |||
|
|||
//@Before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The before annotation is commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was commented out earlier. I didn't make any changes in this class.
Refactored all usages of the mantis mantis client to make use of the interface instead of the actual implementation.
Context
Explain context and other details for this pull request.
Checklist
./gradlew build
compiles code correctly./gradlew test
passes all testsCONTRIBUTING.md