[Part 3] Refactoring Mantis Master Client code into a Gateway interface that defines the spec and a curator based implementation that matches that. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundargates
requested review from
codyrioux,
nickmahilani,
jeffchao,
piygoyal,
calvin681,
Andyz26 and
hmitnflx
as code owners
sundargates
commented
Mar 22, 2022
...ol-plane-client/src/main/java/io/mantisrx/server/master/client/HighAvailabilityServices.java
Show resolved
Hide resolved
sundargates
commented
Mar 22, 2022
...lane-client/src/main/java/io/mantisrx/server/master/client/HighAvailabilityServicesUtil.java
Show resolved
Hide resolved
sundargates
commented
Mar 22, 2022
| private final AsyncHttpClient apiClient; | ||
|
|
||
| @Override | ||
| public CompletableFuture<Ack> updateStatus(Status status) { |
There was a problem hiding this comment.
comment please. also context on why this was added.
…ce that defines the spec and a curator based implementation that matches that. Refactored all usages of the mantis mantis client to make use of the interface instead of the actual implementation
sundargates
force-pushed
the
sundaram/titus_part3
branch
from
7091259
to
90b366c
Compare
calvin681
approved these changes
Mar 22, 2022
Andyz26
reviewed
Mar 22, 2022
| @@ -43,13 +45,16 @@ | |||
| zkProps.put("mantis.zookeeper.connectString", "100.67.80.172:2181,100.67.71.221:2181,100.67.89.26:2181,100.67.71.34:2181,100.67.80.18:2181"); | |||
| zkProps.put("mantis.zookeeper.leader.announcement.path", "/leader"); | |||
| zkProps.put("mantis.zookeeper.root", "/mantis/master"); | |||
| zkProps.put("mantis.localmode", "false"); | |||
| } | |||
|
|
|||
| MasterClientWrapper clientWrapper = null; | |||
|
|
|||
| //@Before | |||
There was a problem hiding this comment.
The before annotation is commented out?
There was a problem hiding this comment.
it was commented out earlier. I didn't make any changes in this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored all usages of the mantis mantis client to make use of the interface instead of the actual implementation.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md