UI service metadata allow GET requests only #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
approved these changes
Oct 28, 2021
| @@ -17,10 +17,10 @@ | |||
| from services.utils import DBConfiguration | |||
|
|
|||
|
|
|||
| def app(loop=None, db_conf: DBConfiguration = None): | |||
| def app(loop=None, db_conf: DBConfiguration = None, middlewares=None): | |||
There was a problem hiding this comment.
maybe add a type hint as well, is middlewares supposed to be a list or something else?
|
This LGTM. I am having @savingoyal also look to make sure they are aware of this change and then we can merge. |
|
@savingoyal is good with the change. Merging. |
romain-intel
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI service exposes
/metadataroute asaiohttpsubapp, which is used by Metaflow Client.Since this is intended for read-only operations we should only allow
GETrequests.