Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ui_backend configuration with json #268

Merged
merged 8 commits into from
Jan 19, 2022

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Nov 24, 2021

Add another method of configuring optional components of the service, as passing massive json configuration as environment variables can become difficult to handle.

The following environment variable configs now have an alternative file config available

  • NOTIFICATIONS - config.notifications.json
  • CUSTOM_QUICKLINKS - config.custom_quicklinks.json
  • PLUGINS - config.plugins.json

This change should not have any adverse effect on existing deployments configured with environment variables. The json file lookup is treated as a fallback only in case an env var is not set.

@saikonen saikonen changed the title feat: support configuration with json feat: support ui_backend configuration with json Nov 24, 2021
@saikonen saikonen added ready-for-review Ready for thorough review. enhancement New feature or request and removed ready-for-review Ready for thorough review. enhancement New feature or request labels Nov 25, 2021
@saikonen
Copy link
Collaborator Author

closing PR as unnecessary feature for the time being.

@saikonen saikonen closed this Nov 29, 2021
@savingoyal savingoyal reopened this Jan 11, 2022
Copy link
Collaborator

@obgibson obgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for plugins, both as env and config file and it worked.

services/ui_backend_service/api/utils.py Show resolved Hide resolved
services/ui_backend_service/docs/plugins.md Outdated Show resolved Hide resolved
@savingoyal savingoyal merged commit da3949d into master Jan 19, 2022
@saikonen saikonen deleted the feat/support-configuration-with-json branch January 27, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for thorough review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants