-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow option to set labels on pods using kubernetes
decorator
#1880
Comments
yes - this has been on our backlog. we had a PR that had to be rolled back due to some issues. stay tuned. |
Would this issue be one open to contributions? I've got a use case that requires setting both After going through the source code, I believe I know what updates would need to be made to support those enhancements. Would be happy to put up a PR and work through that, if the team is interested. Not sure if this has already been handled (as the above comment somewhat suggests). |
Pinging again since we also need both |
#1568 is an inflight PR - if you would like to weigh in with testing that
PR that would be great.
…On Tue, Dec 17, 2024 at 2:47 AM shan ***@***.***> wrote:
Pinging again since we also need both label and annotations
—
Reply to this email directly, view it on GitHub
<#1880 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF2MO2GMXLXKVQXDISNPAL2F76KPAVCNFSM6AAAAABI3L2S4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYGEZDEMZRGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
We would like to add labels to pod generated using
kubernetes
decorator. I see there are some internal labels being set by Metaflow but we would like to pass some external ones too.The text was updated successfully, but these errors were encountered: