Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option to set labels on pods using kubernetes decorator #1880

Open
ShantanuKumar opened this issue Jun 5, 2024 · 4 comments
Open

Allow option to set labels on pods using kubernetes decorator #1880

ShantanuKumar opened this issue Jun 5, 2024 · 4 comments

Comments

@ShantanuKumar
Copy link

We would like to add labels to pod generated using kubernetes decorator. I see there are some internal labels being set by Metaflow but we would like to pass some external ones too.

@savingoyal
Copy link
Collaborator

yes - this has been on our backlog. we had a PR that had to be rolled back due to some issues. stay tuned.

@ggutierrez545-ai
Copy link

Would this issue be one open to contributions? I've got a use case that requires setting both labels and annotations on the jobs that Metaflow creates.

After going through the source code, I believe I know what updates would need to be made to support those enhancements. Would be happy to put up a PR and work through that, if the team is interested. Not sure if this has already been handled (as the above comment somewhat suggests).

@ShantanuKumar
Copy link
Author

Pinging again since we also need both label and annotations

@savingoyal
Copy link
Collaborator

savingoyal commented Dec 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants