feature: stream logs in chunks #1856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
saikonen
commented
May 23, 2024
| @@ -144,3 +150,34 @@ def iter_results(): | |||
| yield r.key, None, None | |||
|
|
|||
| return CloseAfterUse(iter_results(), closer=s3) | |||
|
|
|||
| def stream_bytes(self, paths, chunk_size=2**1024): | |||
There was a problem hiding this comment.
default chunk_size choice is arbitrary here, mainly for testing purposes. For the UI Backend case this should probably be made configurable.
savingoyal
previously approved these changes
May 24, 2024
|
closing this as unnecessary for the planned metaflow-service feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempts to read logs with a fixed byte offset instead of all at once. Motivation is to decrease memory consumption when handling massive log files.