Refactoring 'J2KHeaderParameters' into its own class. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o obtain an instance of a 'J2KHeaderParameters' class from a CPL descriptor, or an MXF descriptor. Added testing to ensure that these methods produce equivalent results.
danielhdz13-netflix
requested review from
palemieux,
fschleich and
davidt-netflix
…ding one more comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J2KHeaderParametersclass from a CPL descriptor, or an MXF descriptor.validateHTto directly take in aJ2KHeaderParametersinstance, rather than the largerCompositionImageEssenceDescriptorModelJ2KHeaderParametersThese changes make it easier for downstream applications to use Photon as an SDK. The HT constraints can be easily validated for standalone MXF files, or for CPLs.