Instrument circuit breaker in the connection pool #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
approved these changes
Nov 2, 2023
| this.maxConnsPerHostExceededCounter = | ||
| SpectatorUtils.newCounter(METRIC_PREFIX + "_maxConnsPerHostExceeded", metricId); | ||
| this.closeWrtBusyConnCounter = SpectatorUtils.newCounter(METRIC_PREFIX + "_closeWrtBusyConnCounter", metricId); | ||
| this.createNewConnCounter = newCounter("_create"); |
There was a problem hiding this comment.
nit: move the _ to the newCounter and newGauge functions so these all read a bit better 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a connection error rate is too high (as measured by DiscoveryResult.isCircuitBreakerTripped()) an active connection is closed when trying to return it to the pool. I don't think this is a great pattern, but I wanted to be able to measure it before making any changes. I added a new counter to track connections closed due to the circuit breaker
I also replaced SpectatorUtils with the injected registry