Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config to disable close on circuit breaker #1755

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add config to disable close on circuit breaker #1755

merged 1 commit into from
Mar 25, 2024
+75 −1

Conversation

jguerra
Copy link
Contributor

@jguerra jguerra commented Mar 22, 2024 •
edited
Loading

Adds a configuration to disable the potentially harmful close on circuit breaker trip behavior

gavinbunney
gavinbunney approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@gavinbunney gavinbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kyagna
kyagna approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@kyagna kyagna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinbunney gavinbunney merged commit fe9a4e8 into master Mar 25, 2024
5 checks passed
@gavinbunney gavinbunney deleted the jg/circuit_breaker_config branch March 25, 2024 21:16
argha-c pushed a commit that referenced this pull request Sep 10, 2024
@jguerra @argha-c
Add config to disable close on circuit breaker (#1755)
ac16262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbunney gavinbunney gavinbunney approved these changes

@kyagna kyagna kyagna approved these changes

@argha-c argha-c Awaiting requested review from argha-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jguerra @gavinbunney @kyagna