Nextcloud 21.0.2

[nethbot]

Update Nextcloud release to 21.0.2

Changelog:
https://nextcloud.com/changelog/

[gsanchietti]

Preliminary work:

• new maria db 10.5 package: https://github.com/NethServer/nethserver-rh-mariadb105
• NC 21 branch: https://github.com/NethServer/nethserver-nextcloud/tree/nc21

Documents from upstream:

• https://docs.nextcloud.com/server/latest/admin_manual/installation/system_requirements.html#database-requirements-for-mysql-mariadb
• https://docs.nextcloud.com/server/stable/admin_manual/configuration_database/linux_database_configuration.html
• https://docs.nextcloud.com/server/latest/admin_manual/configuration_database/mysql_4byte_support.html#

[nethbot]

in 7.9.2009/testing:

• nethserver-rh-mariadb105-0.0.1-1.6.gcd28272.ns7.noarch.rpm x86_64 armhfp aarch64

[nethbot]

in 7.9.2009/testing:

• nethserver-nextcloud-1.16.7-1.20.g60d128a.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Test case 1

• Install on a clean machine with OpenLDAP or AD
• Check everything works as expected

Test case 2

• Update an existing machine with OpenLDAP or AD
• Check everything works as expected
• Verify the database on MariaDB 55 has been deleted

Test case 3

• Update an existing machine where there is at least another application that uses MariaDB
• Verify that the other application is still working after the update
• Verify the database on MariaDB 55 has been deleted

Test case 4

• Install a clean machine with OpenLDAP
• Configure nextcloud at least with one user
• Backup the configuration and the data
• Execute a disaster recovery
• Verify everything has been restore on a new machine

Test case 5

• Install nethserver-nextcloud from updates
• Open /usr/share/nextcloud/config/config.php and add the ooption 'loglevel' => 0 (this step should simulate an installation coming from an old NC release)
• Update from testing
• Verify the migration doesn't fail

[jgelauff]

test case 3 openldap failed.

internal server error after update.
nextcloud database in mariadb55 is delete, but where is the new database?
other applications using mariadb55 are still working

is it possibable to upgrade php also? some nextcloud apps are asking for min php version of 7,4

[gsanchietti]

internal server error after update.

Could you please post the extract from messages and nextcloud logs?

nextcloud database in mariadb55 is delete, but where is the new database?

scl enable rh-mariadb105
mysql --socket /run/rh-mariadb105-mariadb/nextcloud-mysql.sock

is it possibable to upgrade php also? some nextcloud apps are asking for min php version of 7,4

Maybe on next update: one step at time to minimize the errors :)

[jgelauff]

examing the log files show my that the databse was not found bij nextcloud
i have fixed it by modifing the /usr/share/nexcloud/config/config.php setting dbhost

from 'dbhost' => 'localhost',
to
'dbhost' =>'localhost:/run/rh-mariadb105-mariadb/nextcloud-mysql.sock',

the first time the upgrade wizard run there was a php fatal error that the allowed memory size exhausted.
after that nextcloud is in maintaince mode, after a modify to disabled the maintaince mode,
the second upgrade attemp was succesfull

internal server error after update.

Could you please post the extract from messages and nextcloud logs?

nextcloud database in mariadb55 is delete, but where is the new database?

scl enable rh-mariadb105
mysql --socket /run/rh-mariadb105-mariadb/nextcloud-mysql.sock

is it possibable to upgrade php also? some nextcloud apps are asking for min php version of 7,4

Maybe on next update: one step at time to minimize the errors :)

[jgelauff]

there is after the update still a problem with the php memory

system settings was indicating that some indexes are missing
so i tried to run occ db:add-missing-indices
with the error
PHP Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /usr/share/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php on line 133

the same error orrured with the cron jobs

[gsanchietti]

there is after the update still a problem with the php memory

You could try to increase the PHP memory limit:

runuser -u apache -- scl enable rh-php73 --  php -d memory_limit=1024M  /usr/share/nextcloud/occ "<command>"

[jgelauff]

increasing memory was not the solution;
acoording to this thread
nextcloud/server#25742
i have changed the loglevel to 2 and occ en cronjobs are running correctly but this is workarround seems the bug is fixed en merged 3 day ago see nextcloud/server#27334

and i am facing nextcloud/server#26493

and finaly the config.php file must be extended with a default_phone_region setting otherwise a message orrur in the systemsettings

Your installation has no default phone region set. This is required to validate phone numbers in the profile settings without a country code. To allow numbers without a country code, please add “default_phone_region” with the respective ISO 3166-1 code of the region to your config file.

[stephdl]

Your installation has no default phone region set. This is required to validate phone numbers in the profile settings without a country code. To allow numbers without a country code, please add “default_phone_region” with the respective ISO 3166-1 code of the region to your config file.

This is a separated issue because it occurs too with the NC20. What default to take into account, NethServer is an international project :-?

[gsanchietti]

Thank you for your feedback @jgelauff.

Reading linked issue I think we should fix a couple of things:

• disable accessibility app before the upgrade
• remove the original database only of the migration has correctly completed

[jgelauff]

Your installation has no default phone region set. This is required to validate phone numbers in the profile settings without a country code. To allow numbers without a country code, please add “default_phone_region” with the respective ISO 3166-1 code of the region to your config file.

This is a separated issue because it occurs too with the NC20. What default to take into account, NethServer is an international project :-?

perhaps we can document the option in the documantation and show the right command so people can use it correctly or make it a setting in the cockpit app
for example;
occ config:system:set default_phone_region --value="IT"

[nethbot]

in 7.9.2009/testing:

• nethserver-rh-mariadb105-0.0.1-1.8.g141fc9d.ns7.noarch.rpm x86_64 armhfp aarch64

[nethbot]

in 7.9.2009/testing:

• nethserver-nextcloud-1.16.7-1.27.gbec642f.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Back on QA again

[stephdl]

@gsanchietti I updated my personal server, AFAIK I have no problem but I can read this in the administration overview of the admin

The database is missing some primary keys. Due to the fact that adding primary keys on big tables could take some time they were not added automatically. 
By running "occ db:add-missing-primary-keys" those missing primary keys could be added manually while the instance keeps running.
Missing primary key on table "oc_federated_reshares".
Missing primary key on table "oc_systemtag_object_mapping".
Missing primary key on table "oc_comments_read_markers".
Missing primary key on table "oc_collres_resources".
Missing primary key on table "oc_collres_accesscache".
Missing primary key on table "oc_filecache_extended".

The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. 
By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.
Missing optional column "reference_id" in table "oc_comments".

Could you reproduce ?

[nethbot]

in 7.9.2009/testing:

• nethserver-nextcloud-1.16.7-1.28.ga1d6fe1.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Nextcloud 20.0.2 can't correctly open PDF files containing a space inside the name.
See nextcloud/files_pdfviewer#381

We are going to backport the fix.

Thanks to @nrauso for pointing it out

[nethbot]

in 7.9.2009/testing:

• nethserver-nextcloud-1.16.7-1.29.ge20ff3f.ns7.noarch.rpm x86_64 armhfp aarch64

[nrauso]

All test cases have been verified on testing machines.
We need to try to upgrade an installation with a large amount of data before to release the update

[stephdl]

just for information on the instance I have migrated

[root@prometheus ~]# du -h /var/lib/nethserver/nextcloud/
29G	/var/lib/nethserver/nextcloud/

[gsanchietti]

Proposed fix for #6506 (comment), doesn't completely solve the issue.
To reproduce a failing upgrade:

• install nethserver-nextcloud from updates
• add the option 'loglevel' => 0 to /usr/share/nextcloud/config/config.php
• update from testing

The migration will fail because occ can't allocate memory. Also, at the end of the procedure, the system will remain on a non consistent state.

Proposal:

• fix occ by applying this workaround: [NC 21] OCC Update error: allowed memory size exhausted nextcloud/server#25742 (comment)
• do not remove maintenance mode if something fail

[nethbot]

in 7.9.2009/testing:

• nethserver-nextcloud-1.16.7-1.32.g0921465.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Back again to testing, added test case 5.

[nrauso]

All test cases - even the number 5 - have been verified on testing machines.
I'm upgrading some machine in production: I'll keep you posted.

Update: all upgrades on production systems worked as expected! 👌

[nethbot]

in 7.9.2009/updates:

• nethserver-rh-mariadb105-1.0.0-1.ns7.noarch.rpm x86_64 armhfp aarch64

[nethbot]

in 7.9.2009/updates:

• nethserver-nextcloud-1.17.0-1.ns7.noarch.rpm x86_64 armhfp aarch64