New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#384 Initial Changes for confirmation #393

Draft

ssonthal wants to merge 4 commits into NethermindEth:main from ssonthal:384_page_management_deletebyprefix

Contributor

ssonthal commented Sep 18, 2024

Resolves #384

List of Changes -

A new property in IBatchContext called as NullPage set to new Page((*ptr)0).
All DeleteByPrefix methods checking if prefix is empty, then registering the page for future reuse and returning batch.NullPage.

Pending Changes -
Recursively calling for child pages (if the prefix is empty) - need help here.


          Initial Changes for confirmation

b1b927b

ssonthal marked this pull request as draft

September 18, 2024 16:24

ssonthal added 3 commits

September 18, 2024 21:57


          Correction

f6a9393


          Removing extra spaces and lines

ea349a6


          correction NethermindEth#2

376d941

Contributor Author

ssonthal commented Sep 20, 2024

Hey @Scooletz do these changes look good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet