fix: pr review comments

NethermindEth · Jun 23, 2023 · 5f8ebc3 · 5f8ebc3
1 parent 0782ff7
commit 5f8ebc3
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/listings/ch00-introduction/if_else/src/access_control.cairo b/listings/ch00-introduction/if_else/src/access_control.cairo
@@ -3,28 +3,27 @@ mod SimpleAccessControl {
     use starknet::{get_caller_address,ContractAddress};
 
     struct Storage {
-        owner: ContractAddress, 
+        _owner: ContractAddress, 
     }
 
     #[event]
-    fn welcomeEvent(name: felt252) {}
+    fn WelcomeEvent(name: felt252) {}
 
     #[constructor]
-    fn constructor(_address: ContractAddress) {
-        owner::write(_address);
+    fn constructor(address: ContractAddress) {
+        _owner::write(address);
     }
 
-    #[internal]
     fn only_owner() -> bool {
-        return get_caller_address() == owner::read();
+        return get_caller_address() == _owner::read();
     }
 
     #[external]
     fn log_access() {
         if(only_owner()) {
-            welcomeEvent('Welcome Admin!');
+            WelcomeEvent('Welcome Admin!');
         } else {
-            welcomeEvent('Welcome User!');
+            WelcomeEvent('Welcome User!');
         }
     }
 }