Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize chapter-related folder names in */src* #211

Closed
0xNeshi opened this issue Jun 4, 2024 · 7 comments
Closed

Standardize chapter-related folder names in */src* #211

0xNeshi opened this issue Jun 4, 2024 · 7 comments

Comments

@0xNeshi
Copy link
Contributor

0xNeshi commented Jun 4, 2024

TL;DR

Folder names for chapters should use actual names related to their subject's, like: getting-started, components, applications and advanced-concepts.

Folders in question are in /src: https://github.com/NethermindEth/StarknetByExample/tree/main/src

Context

Three out of four chapters use chXX format for their folder names and then there is one src/components folder:
image

To make matters a bit more confusing, the correct order of the chapters is: ch00 > components > ch01 > ch02.

The folder names should be updated in the following way:

  • ch00 -> getting-started
  • ch01 -> applications
  • ch02 -> advanced-concepts
@0xNeshi 0xNeshi changed the title Standardize chapter-related folder names in *src/* Standardize chapter-related folder names in */src* Jun 4, 2024
@raizo07
Copy link
Contributor

raizo07 commented Jun 4, 2024

@misicnenad I'll like to work on this

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jun 6, 2024

@raizo07 just create a draft PR and link this issue, I'll review

@raizo07
Copy link
Contributor

raizo07 commented Jun 6, 2024

@raizo07 just create a draft PR and link this issue, I'll review

Alright, I will.

@raizo07
Copy link
Contributor

raizo07 commented Jun 6, 2024

@misicnenad Here's a link to the draft PR kindly review #216

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Jun 7, 2024

Thanks @raizo07, left a comment for you in the PR

@raizo07
Copy link
Contributor

raizo07 commented Jun 7, 2024

Thanks @raizo07, left a comment for you in the PR

Alright I'll check it out.

@julio4
Copy link
Contributor

julio4 commented Jun 16, 2024

Completed in #216

@julio4 julio4 closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants