Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chapter-related folder names #216

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

raizo07
Copy link
Contributor

@raizo07 raizo07 commented Jun 6, 2024

Issue(s):

Description

Renamed folder names to the standard related names.

Checklist

  • CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
  • Contract Tests: Added tests to cover the changes

Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update all of the references within .md files as well, they're currently broken

@raizo07 raizo07 marked this pull request as ready for review June 7, 2024 09:59
@raizo07
Copy link
Contributor Author

raizo07 commented Jun 7, 2024

Don't forget to update all of the references within .md files as well, they're currently broken

@misicnenad I've fixed them

@0xNeshi
Copy link
Contributor

0xNeshi commented Jun 7, 2024

@julio4 pinging you to check the PR out yourself, all seems good

@0xNeshi
Copy link
Contributor

0xNeshi commented Jun 8, 2024

@raizo07 please resolve the conflicts, so that the branch can be merged

@raizo07
Copy link
Contributor Author

raizo07 commented Jun 8, 2024

@misicnenad @julio4 Merge conflict resolved

@julio4 julio4 merged commit 3fbfb60 into NethermindEth:main Jun 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants