Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cairo cheat sheet #104

Merged
merged 7 commits into from
Oct 31, 2023
Merged

feat: Cairo cheat sheet #104

merged 7 commits into from
Oct 31, 2023

Conversation

Nonnyjoe
Copy link
Contributor

@Nonnyjoe Nonnyjoe commented Oct 29, 2023

Issue(s): Closes (#102)

Description

According to the issue description in (#102), I added the 6 requested syntax and 2 more to a new cheat sheet section in chapter 0.

Also made sure to keep it brief as requested.

Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Overall these are really good.

  • Be sure to follow format standards and run ./scripts/cairo_programs_verifier
  • I think we use mostly LegacyMap and not Dict, so is it possible to replace the dict chapter with a mapping chapter
  • Be sure to not copy cairo-book

src/ch00/cairo_cheatsheet/arrays.md Outdated Show resolved Hide resolved
src/ch00/cairo_cheatsheet/arrays.md Outdated Show resolved Hide resolved
src/ch00/cairo_cheatsheet/felt.md Outdated Show resolved Hide resolved
src/ch00/cairo_cheatsheet/felt.md Outdated Show resolved Hide resolved
src/ch00/cairo_cheatsheet/match.md Outdated Show resolved Hide resolved
@Nonnyjoe Nonnyjoe requested a review from julio4 October 30, 2023 13:26
@Nonnyjoe
Copy link
Contributor Author

All highlighted corrections have been worked on.
I also made sure to run the format and verifier scripts, and both of them were executed without any errors.

Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes and for your contribution! Just a few typos left.

src/ch00/cairo_cheatsheet/felt.md Outdated Show resolved Hide resolved
@julio4
Copy link
Contributor

julio4 commented Oct 31, 2023

@Nonnyjoe I made some small revisions, let me know what you think.

Copy link
Contributor Author

@Nonnyjoe Nonnyjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, thanks for the revisions

@julio4 julio4 merged commit 0d79abb into NethermindEth:main Oct 31, 2023
1 check passed
@julio4 julio4 mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants