Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n]Full zh-cn translation #138

Merged
merged 7 commits into from
Dec 5, 2023
Merged

[i18n]Full zh-cn translation #138

merged 7 commits into from
Dec 5, 2023

Conversation

cryptonerdcn
Copy link
Contributor

@cryptonerdcn cryptonerdcn commented Dec 5, 2023 •
edited
Loading

Issue(s):

Description

Full Chinese translation of StarknetByExample.

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully
  • Contract Tests: Added tests to cover the changes
  • Remix Link: Added a link to open the contract in Remix
  • Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

@cryptonerdcn
Copy link
Contributor Author

@julio4 @enitrat Can you review this PR? Thanks!

@julio4
Copy link
Contributor

julio4 commented Dec 5, 2023

LGTM!

@julio4 julio4 merged commit 2685f61 into NethermindEth:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptonerdcn @julio4 @Skytrc