Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Scarb workspace, CI improvements #141

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

julio4
Copy link
Contributor

@julio4 julio4 commented Dec 6, 2023

Issue(s): #86

Description

This don't add Starknet Foundry support but prepare for a upcoming partial support (where both scarb and snfoundry can be used).

Changes:

  • Use scarb workspace to manage all listing: This allows to use other listings as dependencies (will be useful for components chapters)
  • Update verifier script: Only test modified and added listing (deleting/renaming listings always failed)
  • Add new script 'test_resolver': overwrite scarb test to run snforge test only if snforge is a dependency.
  • Moved 'Contributing' part of the README inside CONTRIBUTING.md
  • Improved documentation

There's an issue with running snforge with scarb's scripts with asdf: unknown command: snforge. Perhaps you have to reshim?. So snforge is not yet ready for use.

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully

@julio4 julio4 changed the title Snfoundry support Chore: Scarb workspace, snfoundry partial support, CI improvements Dec 6, 2023
@julio4 julio4 changed the title Chore: Scarb workspace, snfoundry partial support, CI improvements Chore: Scarb workspace, CI improvements Dec 6, 2023
@julio4 julio4 merged commit 1af1816 into NethermindEth:main Dec 6, 2023
1 check passed
@julio4 julio4 deleted the snfoundry-support branch August 8, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant