Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nft dutch auction #204

Merged
merged 10 commits into from
Jun 9, 2024
Merged

feat: nft dutch auction #204

merged 10 commits into from
Jun 9, 2024

Conversation

princeibs
Copy link
Contributor

@princeibs princeibs commented May 31, 2024

Issue(s): Close #187

Description

In this example, we show the implementation of an NFT minting contract using a Dutch Auction, where the minting price follows a decreasing price curve.

Checklist

  • CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
  • Contract Tests: Added tests to cover the changes

@princeibs princeibs marked this pull request as ready for review June 3, 2024 21:24
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I requested some slight changes, thank you!

Scarb.toml Outdated Show resolved Hide resolved
listings/applications/nft_auction/src/erc20.cairo Outdated Show resolved Hide resolved
listings/applications/nft_auction/src/nft_auction.cairo Outdated Show resolved Hide resolved
listings/applications/nft_auction/src/nft_auction.cairo Outdated Show resolved Hide resolved
@princeibs princeibs requested a review from julio4 June 5, 2024 19:18
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julio4 julio4 merged commit 19c67c2 into NethermindEth:main Jun 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: NFT Dutch Auction
2 participants