Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Advanced factory contract #219

Merged
merged 116 commits into from
Jun 27, 2024
Merged

feat: Advanced factory contract #219

merged 116 commits into from
Jun 27, 2024

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Jun 10, 2024 •
edited
Loading

Issue(s): Close #101

Description

Please provide a brief description of the changes made in this pull request and how they address the related issue.

Checklist

  • CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
  • Contract Tests: Added tests to cover the changes

julio4
julio4 reviewed Jun 11, 2024
View reviewed changes
Scarb.toml Show resolved Hide resolved
listings/applications/advanced_factory/src/campaign/contributions.cairo Outdated Show resolved Hide resolved
listings/applications/advanced_factory/src/campaign/contributions.cairo Outdated Show resolved Hide resolved
src/SUMMARY.md Outdated Show resolved Hide resolved
listings/applications/advanced_factory/src/campaign.cairo Outdated Show resolved Hide resolved
listings/applications/advanced_factory/src/campaign.cairo Outdated Show resolved Hide resolved
listings/applications/advanced_factory/src/campaign.cairo Outdated Show resolved Hide resolved
@0xNeshi 0xNeshi requested a review from julio4 June 12, 2024 11:26
@0xNeshi 0xNeshi force-pushed the adv-factory branch 2 times, most recently from 08827b4 to 94e8e7d Compare June 14, 2024 14:53
@0xNeshi 0xNeshi marked this pull request as ready for review June 17, 2024 11:17
@julio4 julio4 mentioned this pull request Jun 24, 2024
Closed
Nenad added 22 commits June 26, 2024 14:21
@julio4
add initial factory
c3c1781
@julio4
add ownable component
77e0f4c
@julio4
add caller to CounterCreated event
4482699
@julio4
turn counter into campaign
8c4041d
@julio4
fix Campaign interfaced funcs + implement donate
a444ead
@julio4
add _assert_is_ended + update error messages
a29d077
@julio4
_assert_active->_assert_campaign_active
d9facfe
@julio4
_assert_is_ended->_assert_campaign_ended
9436c77
@julio4
implement withdraw
e3ff8de
@julio4
add missing assert success in donate
2ea6f8f
@julio4
add title & description
abd561a
@julio4
update comment
8c255fb
@julio4
implement upgrade
31b84f3
@julio4
clean up internal funcs and imports
cae84c6
@julio4
move hardcoded errors in Errors mod
c45855b
@julio4
donate -> contribute + event rename
2008ed3
@julio4
withdraw -> claim
662a4f3
@julio4
add store impl for contract addr. array
7e13707
@julio4
remove store impl
a0932c8
@julio4
add dynamic array impl
52aa534
@julio4
remove dyn. array
843bb2e
@julio4
remove descr + convert title to felt + convert target to u128
5c6b5c1
Nenad added 24 commits June 26, 2024 14:24
@julio4
remove comment
d8809b7
@julio4
err CLOSED->CANCELED + check active in unpledge
097e9b6
@julio4
contributor->pledger
59e5117
@julio4
add campaign doc content
123229c
@julio4
remove draft status
a97f449
@julio4
add start_time
f3d5a9d
@julio4
remove Status
8f78dc4
@julio4
update doc for campaign
315169c
@julio4
move total_pledges to pledgeable
adaa0b9
@julio4
reorder alphabetically
5fcb4e2
@julio4
remove Launched event + upgrade mock
f0a6586
@julio4
TARGET->GOAL
377c02d
@julio4
reorder params in Details
e25df4e
@julio4
add inline to _refund
36ff85c
@julio4
add new pledgeable tests
af94299
@julio4
add getX tests + add get_pledge_count
ccd2362
@julio4
refactor pledger_to_amount_index->pledger_to_amount
e3c9f55
@julio4
Add tests with 1000 pledgers
131346d
@julio4
add test for add + update existing pledger
d1477c4
@julio4
reenable lib
4eba1ed
@julio4
Add link to adv. factory in crowdfunding point 9
f702709
@julio4
write the adv. factory chapter
ab66865
@julio4
upgrade_campaign_implementation-> upgrade_campaign + comment updates
cfd7694
@julio4
rename get_pledgers_as_arr->array
5c39c5a
julio4
julio4 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@julio4 julio4 merged commit 52fbc5c into NethermindEth:main Jun 27, 2024
1 check passed
@0xNeshi 0xNeshi deleted the adv-factory branch June 27, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio4 julio4 julio4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Advanced factory contract
2 participants
@0xNeshi @julio4