Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat constructor #32

Merged
merged 11 commits into from
Jun 20, 2023
Merged

Feat constructor #32

merged 11 commits into from
Jun 20, 2023

Conversation

StarkFishinator
Copy link
Contributor

Here is an example of how to use constructors in cairo.

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments that need to be addressed before merge.

book.toml Outdated Show resolved Hide resolved
listings/ch00-introduction/constructor/src/lib.cairo Outdated Show resolved Hide resolved
src/ch00-06-constructor.md Outdated Show resolved Hide resolved
listings/ch00-introduction/constructor/Scarb.toml Outdated Show resolved Hide resolved
src/ch00-06-constructor.md Outdated Show resolved Hide resolved
src/ch00-06-constructor.md Outdated Show resolved Hide resolved
StarkFishinator and others added 6 commits June 20, 2023 11:58
* Add Map example

* Fix mapping documentation

* fix: minor fixes

---------

Co-authored-by: msaug <msaug@protonmail.com>
src/ch00-07-constructor.md Outdated Show resolved Hide resolved
src/ch00-07-constructor.md Outdated Show resolved Hide resolved
listings/ch00-introduction/constructor/src/lib.cairo Outdated Show resolved Hide resolved
# See more keys and their definitions at https://docs.swmansion.com/scarb/docs/reference/manifest

[dependencies]
starknet = "1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing [[target.starknet-contract]] line

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Tyvm @StarkFishinator 💯

@enitrat enitrat merged commit 8373d82 into main Jun 20, 2023
@enitrat enitrat mentioned this pull request Jun 20, 2023
@julio4 julio4 deleted the feat---constructor branch August 23, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants