Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simple defi vault #37

Merged
merged 4 commits into from
Jun 23, 2023
Merged

feat: simple defi vault #37

merged 4 commits into from
Jun 23, 2023

Conversation

julio4
Copy link
Contributor

@julio4 julio4 commented Jun 21, 2023

Close #18

@enitrat
Copy link
Collaborator

enitrat commented Jun 21, 2023

We might need to give credit to https://solidity-by-example.org/ for this implementation

@julio4
Copy link
Contributor Author

julio4 commented Jun 21, 2023

We might need to give credit to https://solidity-by-example.org/ for this implementation

Yes for sure. Or do you want to make a slightly different version?

@enitrat
Copy link
Collaborator

enitrat commented Jun 21, 2023

Yes for sure. Or do you want to make a slightly different version?

I like this one, it's easy to understand what's happening

@julio4 julio4 marked this pull request as ready for review June 22, 2023 08:02
enitrat
enitrat approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

listings/ch01-applications/simple_vault/src/simple_vault.cairo Show resolved Hide resolved
@enitrat enitrat merged commit f0fadc9 into NethermindEth:main Jun 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Defi - simple Vault
2 participants
@julio4 @enitrat