Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(if-else): add if-else access control #44

Merged
merged 8 commits into from
Jun 23, 2023

Conversation

HansBhatia
Copy link
Contributor

@HansBhatia HansBhatia commented Jun 22, 2023

Closes #40

@enitrat
Copy link
Collaborator

enitrat commented Jun 23, 2023

added if_else #40

A good practice is to link your PRs to existing issues with predefined keywords, like Closes: e.g.
Closes #40

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@HansBhatia HansBhatia requested a review from enitrat June 23, 2023 17:42
@HansBhatia HansBhatia marked this pull request as draft June 23, 2023 17:43
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after addressing the last small comments ;)

@HansBhatia HansBhatia marked this pull request as ready for review June 23, 2023 17:47
@HansBhatia
Copy link
Contributor Author

HansBhatia commented Jun 23, 2023

Changes made! I cannot merge :)

@HansBhatia HansBhatia requested a review from enitrat June 23, 2023 18:41
@enitrat
Copy link
Collaborator

enitrat commented Jun 23, 2023

I just realized @HansBhatia, you forgot to add a .md page under the src directory with a short explanation of if-else and the code written

@HansBhatia
Copy link
Contributor Author

@enitrat I believe the changes are made!

@enitrat
Copy link
Collaborator

enitrat commented Jun 23, 2023

Great!
You also need to add the chapter to the SUMMARY.md file for it to appear in the book.
Also, I renamed "control" to "log", given that our contract is no longer controlling anything, but just logging.

@enitrat enitrat merged commit 0f43836 into NethermindEth:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: if-else
2 participants