Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add links to Remix with the Starknet plugin enabled and the file #67

Merged
merged 2 commits into from
Aug 24, 2023
Merged

feat: add links to Remix with the Starknet plugin enabled and the file #67

merged 2 commits into from
Aug 24, 2023

Conversation

EdgarBarrantes
Copy link
Member

Closes #60

@EdgarBarrantes EdgarBarrantes requested a review from julio4 August 24, 2023 09:14
julio4
julio4 requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one url to fix.

src/ch02-01-upgradeable_contract.md Outdated Show resolved Hide resolved
@EdgarBarrantes EdgarBarrantes requested a review from julio4 August 24, 2023 14:30
julio4
julio4 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

@julio4 julio4 merged commit 97b1267 into main Aug 24, 2023
@julio4
Copy link
Contributor

julio4 commented Aug 24, 2023

CI should be fixed after #66

@EdgarBarrantes EdgarBarrantes mentioned this pull request Aug 24, 2023
Closed
@enitrat
Copy link
Collaborator

enitrat commented Aug 25, 2023

Did you tweet? 🔥

@julio4
Copy link
Contributor

julio4 commented Aug 25, 2023

@enitrat Not yet, CI is broken so it's not deployed yet. Waiting for #66 (if you can approve by the way)

@julio4 julio4 mentioned this pull request Aug 31, 2023
Closed
@julio4 julio4 deleted the integrate-remix branch September 14, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio4 julio4 julio4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Remix cairo integration
3 participants
@EdgarBarrantes @julio4 @enitrat