Disable automaxprocs logging #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshklop
force-pushed
the
joshklop/automaxprocs-log
branch
from
6a3ee99 to
38c161b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 73.25% 73.22% -0.03%
==========================================
Files 101 101
Lines 10377 10381 +4
==========================================
Hits 7602 7602
- Misses 2214 2220 +6
+ Partials 561 559 -2 ☔ View full report in Codecov by Sentry. |
joshklop
force-pushed
the
joshklop/automaxprocs-log
branch
2 times, most recently
from
349d9f4 to
6d423a4
Compare
omerfirmak
approved these changes
Jan 11, 2024
When imported using the blank identifier `_`, the automaxprocs package emits a log after it changes GOMAXPROCS. According to [1], the authors wanted to log by default, as setting a global like GOMAXPROCS is a significant change which would be surprising if it was done silently because some package imported automaxprocs. Since no one should be importing `cmd/juno` and because we want our log messages to be consistent, we disable the log by calling Set() explicitly. [1] uber-go/automaxprocs#18
joshklop
force-pushed
the
joshklop/automaxprocs-log
branch
from
6d423a4 to
6dfb395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.