Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build binaries pipeline #2121

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

derrix060
Copy link
Contributor

@derrix060 derrix060 commented Sep 5, 2024

Changes made:

  • build macOS arm and x86
  • rename architecture from amd64 to x86_64, which is much easier to distinct from arm
  • remove unnecessary step for self-hosted which is not being used anymore
  • create ARTIFACT_NAME env var, so it's much easier to read the code
  • remove unnecessary id
  • add trigger on PR that change the build binaries files

@derrix060 derrix060 force-pushed the mario/add-mac-arm-on-build-binaries branch 2 times, most recently from 9562d16 to 7e97e28 Compare September 5, 2024 09:30
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (c0008d7) to head (9f742cf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
+ Coverage   78.23%   78.32%   +0.08%     
==========================================
  Files         100      100              
  Lines        9126     9126              
==========================================
+ Hits         7140     7148       +8     
+ Misses       1345     1341       -4     
+ Partials      641      637       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Changes made:
- build macOS arm and x86
- rename architecture from amd64 to x86_64, which is much easier to distinct from arm
- remove unnecessary step for self-hosted which is not being used anymore
- create ARTIFACT_NAME env var, so it's much easier to read the code
- remove unnecessary id
- add trigger on PR that change the build binaries files
- get architecture during runtime
@derrix060 derrix060 force-pushed the mario/add-mac-arm-on-build-binaries branch from 7e97e28 to 9f742cf Compare September 5, 2024 10:39
@derrix060 derrix060 enabled auto-merge (rebase) September 5, 2024 10:42
@derrix060
Copy link
Contributor Author

@derrix060 derrix060 merged commit dc91f9b into main Sep 5, 2024
14 checks passed
@derrix060 derrix060 deleted the mario/add-mac-arm-on-build-binaries branch September 5, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants